Skip to content

Conversation

@alexander-alderman-webb
Copy link
Contributor

@alexander-alderman-webb alexander-alderman-webb commented Jan 30, 2026

Description

Stop mocking transport layer of mcp package in tests.

The SSE server and client are run in-process by using an in-memory object queue to pass messages.

Issues

Reminders

@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • feat(span-streaming): Add experimental trace_lifecycle switch (1) by sentrivana in #5397

Bug Fixes 🐛

  • fix(arq): handle settings_cls passed as keyword argument by nc9 in #5393
  • fix(dramatiq): cleanup isolated scope and transaction when message is skipped by frankie567 in #5346
  • fix(google-genai): deactivate google genai when langchain is used by shellmayr in #5389

Internal Changes 🔧

Fastmcp

  • test(fastmcp): Use AsyncClient for SSE by alexander-alderman-webb in #5400
  • test(fastmcp): Simulate stdio transport with memory streams by alexander-alderman-webb in #5333
  • test(fastmcp): Use TestClient for Streamable HTTP by alexander-alderman-webb in #5384

Mcp

  • test(mcp): Use AsyncClient for SSE by alexander-alderman-webb in #5396
  • test(mcp): Simulate stdio transport with memory streams by alexander-alderman-webb in #5329
  • test(mcp): Use TestClient for Streamable HTTP by alexander-alderman-webb in #5383

Other

  • ci: migration to the new codecov action by MathurAditya724 in #5392

🤖 This preview updates automatically when you update the PR.

@alexander-alderman-webb alexander-alderman-webb changed the title test(mcp): Simulate stdio transport with memory streams test(fastmcp): Use AsyncClient for SSE Jan 30, 2026
@alexander-alderman-webb alexander-alderman-webb marked this pull request as ready for review January 30, 2026 13:07
@alexander-alderman-webb alexander-alderman-webb requested a review from a team as a code owner January 30, 2026 13:07
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2026

Codecov Results 📊

2101 passed | ⏭️ 103 skipped | Total: 2204 | Pass Rate: 95.33% | Execution Time: 5m 7s

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 11492 uncovered lines.

Files with missing lines (171)
File Patch % Lines
langchain.py 3.28% ⚠️ 590 Missing
openai.py 5.63% ⚠️ 486 Missing
utils.py 0.00% ⚠️ 479 Missing
__init__.py 5.08% ⚠️ 374 Missing
starlette.py 5.34% ⚠️ 337 Missing
mcp.py 4.85% ⚠️ 255 Missing
anthropic.py 9.43% ⚠️ 240 Missing
__init__.py 3.93% ⚠️ 220 Missing
langgraph.py 5.29% ⚠️ 215 Missing
span_processor.py 0.00% ⚠️ 205 Missing
__init__.py 5.14% ⚠️ 203 Missing
strawberry.py 8.54% ⚠️ 182 Missing
utils.py 84.68% ⚠️ 140 Missing and 39 partials
aws_lambda.py 16.50% ⚠️ 167 Missing
spark_driver.py 0.00% ⚠️ 166 Missing
huggingface_hub.py 8.89% ⚠️ 164 Missing
sanic.py 9.60% ⚠️ 160 Missing
tracing_utils.py 79.90% ⚠️ 119 Missing and 33 partials
aiohttp.py 10.84% ⚠️ 148 Missing
ai_client.py 0.00% ⚠️ 145 Missing
litellm.py 0.00% ⚠️ 138 Missing
litestar.py 9.59% ⚠️ 132 Missing
starlite.py 8.33% ⚠️ 132 Missing
falcon.py 8.94% ⚠️ 112 Missing
flask.py 12.50% ⚠️ 112 Missing
asgi.py 20.71% ⚠️ 111 Missing
cohere.py 12.70% ⚠️ 110 Missing
dramatiq.py 0.00% ⚠️ 110 Missing
agent_run.py 0.00% ⚠️ 110 Missing
arq.py 9.92% ⚠️ 109 Missing
asgi.py 0.00% ⚠️ 109 Missing
pymongo.py 10.17% ⚠️ 106 Missing
beat.py 8.62% ⚠️ 106 Missing
caching.py 0.00% ⚠️ 106 Missing
utils.py 0.00% ⚠️ 103 Missing
scope.py 92.18% ⚠️ 63 Missing and 38 partials
templates.py 0.00% ⚠️ 100 Missing
asyncpg.py 11.61% ⚠️ 99 Missing
quart.py 16.10% ⚠️ 99 Missing
gcp.py 0.00% ⚠️ 98 Missing
otlp.py 0.00% ⚠️ 97 Missing
utils.py 13.39% ⚠️ 97 Missing
pyramid.py 13.76% ⚠️ 94 Missing
tornado.py 14.55% ⚠️ 94 Missing
client.py 88.48% ⚠️ 56 Missing and 37 partials
__init__.py 0.00% ⚠️ 93 Missing
models.py 5.15% ⚠️ 92 Missing
bottle.py 11.65% ⚠️ 91 Missing
middleware.py 0.00% ⚠️ 90 Missing
agent_run.py 0.00% ⚠️ 90 Missing
tracing.py 87.37% ⚠️ 60 Missing and 27 partials
_wsgi_common.py 31.50% ⚠️ 87 Missing
beam.py 0.00% ⚠️ 84 Missing
loguru.py 11.58% ⚠️ 84 Missing
ray.py 0.00% ⚠️ 84 Missing
invoke_agent.py 0.00% ⚠️ 79 Missing
runner.py 0.00% ⚠️ 77 Missing
clickhouse_driver.py 17.58% ⚠️ 75 Missing
pure_eval.py 0.00% ⚠️ 73 Missing
ariadne.py 14.46% ⚠️ 71 Missing
gql.py 10.13% ⚠️ 71 Missing
hub.py 67.36% ⚠️ 63 Missing and 7 partials
sqlalchemy.py 10.26% ⚠️ 70 Missing
fastapi.py 15.85% ⚠️ 69 Missing
graphene.py 12.82% ⚠️ 68 Missing
spotlight.py 55.56% ⚠️ 64 Missing and 3 partials
transactions.py 0.00% ⚠️ 67 Missing
rq.py 15.38% ⚠️ 66 Missing
streaming.py 0.00% ⚠️ 66 Missing
huey.py 17.72% ⚠️ 65 Missing
boto3.py 14.86% ⚠️ 63 Missing
utils.py 16.00% ⚠️ 63 Missing
transport.py 88.35% ⚠️ 46 Missing and 16 partials
httpx.py 16.44% ⚠️ 61 Missing
chalice.py 16.18% ⚠️ 57 Missing
propagator.py 0.00% ⚠️ 57 Missing
server.py 0.00% ⚠️ 56 Missing
spark_worker.py 0.00% ⚠️ 56 Missing
graph_nodes.py 0.00% ⚠️ 52 Missing
_async_common.py 0.00% ⚠️ 51 Missing
views.py 0.00% ⚠️ 50 Missing
tools.py 0.00% ⚠️ 49 Missing
caches.py 16.95% ⚠️ 49 Missing
transaction_profiler.py 90.15% ⚠️ 33 Missing and 16 partials
_asgi_common.py 16.67% ⚠️ 45 Missing
signals_handlers.py 0.00% ⚠️ 44 Missing
invoke_agent.py 0.00% ⚠️ 43 Missing
utils.py 85.99% ⚠️ 36 Missing and 5 partials
client.py 0.00% ⚠️ 40 Missing
_sync_common.py 22.00% ⚠️ 39 Missing
client.py 0.00% ⚠️ 38 Missing
_queue.py 68.89% ⚠️ 28 Missing and 8 partials
continuous_profiler.py 92.01% ⚠️ 25 Missing and 11 partials
server.py 0.00% ⚠️ 35 Missing
monitoring.py 62.20% ⚠️ 31 Missing
launchdarkly.py 0.00% ⚠️ 31 Missing
trytond.py 0.00% ⚠️ 30 Missing
tools.py 0.00% ⚠️ 30 Missing
integration.py 0.00% ⚠️ 30 Missing
error_tracing.py 0.00% ⚠️ 29 Missing
envelope.py 92.35% ⚠️ 15 Missing and 13 partials
redis_cluster.py 26.47% ⚠️ 25 Missing
logging.py 96.08% ⚠️ 6 Missing and 18 partials
typer.py 0.00% ⚠️ 24 Missing
tasks.py 0.00% ⚠️ 24 Missing
statsig.py 0.00% ⚠️ 23 Missing
execute_tool.py 0.00% ⚠️ 23 Missing
queries.py 25.81% ⚠️ 23 Missing
api.py 89.26% ⚠️ 16 Missing and 6 partials
session.py 91.11% ⚠️ 8 Missing and 14 partials
__init__.py 80.43% ⚠️ 18 Missing and 4 partials
rust_tracing.py 90.21% ⚠️ 14 Missing and 8 partials
ai_client.py 15.38% ⚠️ 22 Missing
utils.py 61.11% ⚠️ 21 Missing and 1 partials
sessions.py 90.98% ⚠️ 12 Missing and 9 partials
worker.py 82.80% ⚠️ 16 Missing and 5 partials
unraisablehook.py 0.00% ⚠️ 21 Missing
__init__.py 8.70% ⚠️ 21 Missing
openfeature.py 0.00% ⚠️ 20 Missing
execute_tool.py 0.00% ⚠️ 20 Missing
unleash.py 0.00% ⚠️ 19 Missing
_werkzeug.py 51.85% ⚠️ 13 Missing and 5 partials
_openai_completions_api.py 21.74% ⚠️ 18 Missing
model_request.py 0.00% ⚠️ 18 Missing
wsgi.py 91.41% ⚠️ 11 Missing and 6 partials
_batcher.py 86.25% ⚠️ 11 Missing and 5 partials
utils.py 0.00% ⚠️ 16 Missing
atexit.py 56.25% ⚠️ 14 Missing and 1 partials
excepthook.py 56.25% ⚠️ 14 Missing and 1 partials
redis.py 25.00% ⚠️ 15 Missing
cloud_resource_context.py 91.03% ⚠️ 13 Missing
gnu_backtrace.py 88.24% ⚠️ 6 Missing and 7 partials
__init__.py 27.78% ⚠️ 13 Missing
serializer.py 95.16% ⚠️ 9 Missing and 3 partials
executing.py 81.58% ⚠️ 7 Missing and 5 partials
threading.py 92.63% ⚠️ 7 Missing and 4 partials
redis_py_cluster_legacy.py 26.67% ⚠️ 11 Missing
asyncio.py 90.00% ⚠️ 8 Missing and 2 partials
utils.py 41.18% ⚠️ 10 Missing
monitor.py 91.80% ⚠️ 5 Missing and 4 partials
__init__.py 72.41% ⚠️ 8 Missing and 1 partials
_types.py 80.00% ⚠️ 6 Missing and 1 partials
handoff.py 0.00% ⚠️ 7 Missing
consts.py 0.00% ⚠️ 7 Missing
rb.py 30.00% ⚠️ 7 Missing
_openai_responses_api.py 33.33% ⚠️ 6 Missing
logger.py 94.87% ⚠️ 2 Missing and 2 partials
dedupe.py 95.00% ⚠️ 2 Missing and 2 partials
stdlib.py 99.25% ⚠️ 1 Missing and 3 partials
consts.py 0.00% ⚠️ 4 Missing
__init__.py 20.00% ⚠️ 4 Missing
__init__.py 0.00% ⚠️ 4 Missing
feature_flags.py 93.75% ⚠️ 2 Missing and 1 partials
serverless.py 94.44% ⚠️ 2 Missing and 1 partials
socket.py 96.00% ⚠️ 2 Missing and 1 partials
__init__.py 0.00% ⚠️ 3 Missing
__init__.py 40.00% ⚠️ 3 Missing
__init__.py 0.00% ⚠️ 3 Missing
__init__.py 0.00% ⚠️ 3 Missing
__init__.py 0.00% ⚠️ 3 Missing
_compat.py 94.87% ⚠️ 2 Missing
_log_batcher.py 100.00% ⚠️ 2 partials
consts.py 99.43% ⚠️ 2 Missing
debug.py 95.65% ⚠️ 1 Missing and 1 partials
scrubber.py 100.00% ⚠️ 2 partials
agent_workflow.py 71.43% ⚠️ 2 Missing
_init_implementation.py 100.00% ⚠️ 1 partials
_metrics_batcher.py 100.00% ⚠️ 1 partials
argv.py 100.00% ⚠️ 1 partials
consts.py 0.00% ⚠️ 1 Missing
consts.py 0.00% ⚠️ 1 Missing

Generated by Codecov Action

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants